Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Tessera AWS Secrets Manager implementation #919

Merged
merged 23 commits into from
Feb 10, 2020

Conversation

Emi14
Copy link
Contributor

@Emi14 Emi14 commented Dec 20, 2019

No description provided.

Krish1979
Krish1979 previously approved these changes Dec 23, 2019
Copy link
Collaborator

@chris-j-h chris-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the suggested changes so that the docs reflect our updated config

docs/Privacy/Tessera/Configuration/Keys.md Outdated Show resolved Hide resolved
docs/Privacy/Tessera/Configuration/Keys.md Outdated Show resolved Hide resolved
docs/Privacy/Tessera/Configuration/Keys.md Outdated Show resolved Hide resolved
docs/Privacy/Tessera/Configuration/Keys.md Outdated Show resolved Hide resolved
docs/Privacy/Tessera/Configuration/Keys.md Outdated Show resolved Hide resolved
docs/Privacy/Tessera/Configuration/Keys.md Outdated Show resolved Hide resolved
@Emi14
Copy link
Contributor Author

Emi14 commented Jan 10, 2020

@chris-j-h could you please take another look?

chris-j-h
chris-j-h previously approved these changes Jan 10, 2020
Copy link
Collaborator

@chris-j-h chris-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Krish1979
Krish1979 previously approved these changes Jan 10, 2020
@jpmsam
Copy link
Contributor

jpmsam commented Jan 10, 2020

Thank you @Emi14 and Ionut. We'll merge it after the Tessera release.

@Krish1979 Krish1979 dismissed stale reviews from chris-j-h and themself via 9c2cba6 February 10, 2020 15:35
@Krish1979 Krish1979 merged commit a5d3293 into Consensys:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants